Repository navigation
Add tests for petition-workspace scripts; fix partial filing on name clash - #1
Open
Selcukatli wants to merge 1 commit into
Open
Selcukatli wants to merge 1 commit into
Selcukatli wants to merge 1 commit into
Conversation
…clash Adds a node:test suite that runs scaffold-case.sh and add-evidence.mjs against temp dirs (criteria counts, routing, URL/multi-file/move/dry-run, validation errors), wired into `npm test` and CI. add-evidence.mjs checked for existing destinations inside the copy loop, so a clash on the second file left the first one filed with no row in evidence-list.md. It now checks every destination before copying any. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/workspace.test.mjs(17node:testcases) runs the realscaffold-case.shandadd-evidence.mjsagainst temp dirs. It covers O-1A/EB-1A criteria counts and names, criterion-7 routing, URL, multi-file,--moveand--dry-runrows, and the error paths (invalid criterion, missing-p, formatter-escaped markers, non-empty target).npm test(test:workspace) and the CI workflow.add-evidence.mjssays it files atomically, but it checked for overwrites inside the copy loop. A clash on file 2 left file 1 filed with no row recorded. It now checks every destination before copying anything.Verification
npm testexits 0 (validate + check-pii + 17/17 workspace tests). The clash test failed before the fix.bothcase, filed evidence, triggered a clash (exit 2, nothing partially filed, the evidence list unchanged), and built the portal packet.🤖 Generated with Claude Code