Skip to content

fix(install): preserve paid app destinations - #239

Merged
SebastienElet merged 1 commit into
mainfrom
fix/229-paid-app-skip
Aug 26, 2026
Merged

fix(install): preserve paid app destinations#239
SebastienElet merged 1 commit into
mainfrom
fix/229-paid-app-skip

Conversation

@SebastienElet

Copy link
Copy Markdown
Owner

Summary

  • keep paid-app skip mode from creating fake Flow, Things 3, or DaisyDisk bundles
  • preserve replayability by leaving missing destinations absent while reporting the skipped state
  • exercise the real public Make targets with temporary destinations and a substituted installation provider

Validation

  • bun test tooling/paid-apps.test.ts — 10 passed
  • bun test — 313 passed, 4 skipped
  • bun run format:typescript:check
  • bun run lint
  • bun run typecheck
  • safe make -sBn for flow, things-3, and daisydisk

Fixes #229

@SebastienElet
SebastienElet force-pushed the fix/229-paid-app-skip branch from 702e11b to 1c19b36 Compare August 26, 2026 11:02
@SebastienElet
SebastienElet force-pushed the fix/229-paid-app-skip branch from 1c19b36 to b34b0f3 Compare August 26, 2026 11:06
@SebastienElet

Copy link
Copy Markdown
Owner Author

Repair record

Review completed on b34b0f3149c52bf936729103ec8138d968615b6c: paid-app skip mode leaves destinations absent, a later normal run installs each missing app once, and existing destinations remain untouched; the final diff and 18 real Make invocations establish those transitions.

Corrections pushed:

  • Rebased onto main at 045fdee0cdc2362f26612ff8a089a727faca789d — mechanism: the stale head omitted the CI timeout correction, allowing Bun's implicit 5-second limit to kill a valid subprocess test at 5000.61 ms; proof: the workflow contract failed before the command changed, then the final local barrier and both GitHub Bun jobs passed with the explicit 15-second suite timeout.

Not repaired:

  • None.

Barrier: behavior tier on macOS 26.6.2 arm64 with Bun 1.4.0 — TypeScript format checked 103 files; lint and typecheck reported 0 errors and 0 warnings; 314/317 tests passed, 3 external integrations skipped, 0 failed, with 1522 assertions across 35 files; 3/3 paid-app Make dry-runs were valid. Limits: Ubuntu was not reproduced locally, no real App Store purchase was exercised, and make all was not run locally because it mutates the host; GitHub's macOS and Ubuntu deployment jobs and both Bun jobs passed on this head.

@SebastienElet
SebastienElet merged commit 1e4d1b7 into main Aug 26, 2026
28 checks passed
@SebastienElet
SebastienElet deleted the fix/229-paid-app-skip branch August 26, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep SKIP_PAID_APPS from creating fake application bundles

1 participant