Move PupuID helpers to OpenVIII and disable viewports on non-MSVC#236
Open
Sebanisu wants to merge 7 commits into
Open
Move PupuID helpers to OpenVIII and disable viewports on non-MSVC#236Sebanisu wants to merge 7 commits into
Sebanisu wants to merge 7 commits into
Conversation
Replace editor-local PupuID and UniquifyPupu implementations with the shared versions from open_viii::graphics::background and update all dependent code paths accordingly. Remove duplicate source files and CMake entries now that the functionality is provided by OpenVIII. Also disable ImGui multi-viewports by default on non-MSVC builds. Viewports remain enabled on MSVC where support is known to be stable, avoiding window-management issues seen under Wayland tiling compositors while leaving room for a future user-configurable option.
code to use OpenVIII's TileOperations API. Changes: - Delete duplicated tile_operations.hpp implementations from experimental and main code paths - Replace local tile_operations references with open_viii::graphics::background::tile_operations - Include TileOperations.hpp directly where needed - Update tile filters and predicates to use shared OpenVIII types - Fix MoveTiles operation construction by providing explicit TileT template arguments and value casts - Update swizzle/deswizzle tile function definitions to use shared operation types - Migrate filter, sprite, and map operation code to shared tile operation aliases This consolidates tile operation logic into OpenVIII and removes duplicate implementations from Field Map Editor.
Use the preview MSVC toolset when building with Visual Studio to work around a compiler regression affecting std::source_location::current() default arguments. This is a temporary workaround until the fix is available in a stable MSVC release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the effort to move duplicated Field Map Editor functionality into OpenVIII and reduce editor-specific maintenance.
PupuID and UniquifyPupu Migration
PupuIDandUniquifyPupuimplementations with the shared versions fromopen_viii::graphics::backgroundTileOperations Migration
tile_operationsimplementations from both experimental and main editor code pathsopen_viii::graphics::background::tile_operationsPlatform-Specific Viewport Handling
Build System
std::source_location::current()default-argument usageOverall, this PR further consolidates shared functionality into OpenVIII, removes duplicated editor code, reduces long-term maintenance costs, and improves build stability across supported platforms.