Remove duplicate fmt formatter specialization and update upstream.#235
Merged
Conversation
Delete local formatter specializations for BlendModeT, BPPT, and Point now provided or instantiated earlier by upstream OpenVIII_CPP_WIP headers. Fixes fmt v11 redefinition and specialization-after-instantiation build errors.
Replace deprecated positional Png::save arguments with SaveSettings initialization to match upstream OpenVIII_CPP_WIP API changes.
- add fmt to vcpkg dependencies - pin fmt version to 12.0.0 - update vcpkg builtin baseline
Refactors formatting and layout in `import.cpp` for improved readability and consistency.
Also replaces implicit optional clearing:
```cpp
m_import_image_map = {};
```
with the more explicit:
```cpp
m_import_image_map.reset();
```
## Changes
- Reformat multiline `ImGui::*` conditionals
- Normalize wrapping of `if constexpr` and comparison expressions
- Align local variable spacing
- Replace optional clearing assignment with `.reset()`
- General readability cleanup in import GUI code
## Notes
No functional changes intended besides the explicit optional reset behavior.
Sebanisu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete local formatter specializations for BlendModeT, BPPT, and Point now provided or instantiated earlier by upstream OpenVIII_CPP_WIP headers.
Fixes fmt v11 redefinition and specialization-after-instantiation build errors.
Refactors formatting and layout in
import.cppfor improved readability and consistency.Also replaces implicit optional clearing:
m_import_image_map = {};with the more explicit:
Changes
ImGui::*conditionalsif constexprand comparison expressions.reset()Notes
No functional changes intended besides the explicit optional reset behavior.
Replace deprecated positional Png::save arguments with
SaveSettings initialization to match upstream OpenVIII_CPP_WIP
API changes.
build: add fmt dependency and update vcpkg baseline