Skip to content

Fix releasefile handle leak - #1098

Merged
foodprocessor merged 7 commits into
mainfrom
fix/releasefile-handle-leak
Oct 27, 2026
Merged

foodprocessor merged 7 commits into
mainfrom
fix/releasefile-handle-leak

Conversation

@foodprocessor

@foodprocessor foodprocessor commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

What type of Pull Request is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Describe your changes in brief

Free file handle resources on calls to release regardless of upload errors.
Retry uploads which fail on close, except when they fail with ENOSPC, which we don't retry.
Also clean up, and parse more errors in libfuse.

Checklist

  • Tested locally
  • Added new dependencies
  • Updated documentation
  • Added tests

@jfantinhardesty jfantinhardesty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread component/stream/read_write.go Resolved
Comment thread component/file_cache/file_cache.go Resolved
@foodprocessor
foodprocessor merged commit 128cf2e into main Oct 27, 2026
29 checks passed
@foodprocessor
foodprocessor deleted the fix/releasefile-handle-leak branch October 27, 2026 21:49

This branch was previously deployed

1 inactive deployment
testing — 14061fbc Deployed Oct 27, 2026 by foodprocessor via Cleanup Test Accounts (1.27, linux) #3893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants