Validate seed files - #381
Merged
Merged
Conversation
…nitions - tags are present - implications have at least one conclusion and at least assumption (possibly associated) - assigned properties of structures are disjoint new rule: check_redundancy can only be set as `false` (since `true` is the default anyway)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes very late (and could have been done already in #164), but the seed YAML files (for categories, functors, properties, implications, etc.) are now properly validated before they are inserted into the database, using the validation library Valibot. The database validates the data as well, but validating it beforehand is preferable because it allows for more user-friendly and custom error messages, and some very specific checks cannot be performed at the database level anyway.
The validation adds another boundary between the YAML files and the seed script, allowing the type casts that assumed a particular structure to be removed. Previously, invalid data would often simply cause the seed script to crash; this will no longer happen.
To have a schema for structures that works uniformly for categories, functors, etc., associated structures (such as the domain of a functor or the category of a morphism) have been grouped under a new
associatedkey; they are no longer at the root level. All files for functors, morphisms, and symmetric monoidal categories have been restructured accordingly.