chore: migrate clock app to standalone repo#845
Conversation
- remove source files from edge-apps/clock - add redirect notice in edge-apps/clock/README.md - relocate icon to edge-apps/icons/clock-edge-app.svg - update README.md to link to Screenly/clock-edge-app
PR Reviewer Guide 🔍(Review updated until commit 3be901d)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Pull request overview
This PR migrates the Clock Edge App out of the Playground monorepo by removing the in-repo Clock implementation and updating documentation to point to the new standalone repository (Screenly/clock-edge-app).
Changes:
- Removed the Clock app source code, tests, and app-specific configuration/manifests from
edge-apps/clock. - Replaced the Clock app README with a migration notice linking to the standalone repo.
- Updated the root README Clock app link and added a Clock icon under
edge-apps/icons.
Reviewed changes
Copilot reviewed 17 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates the Clock App entry to point to the standalone repository. |
| edge-apps/icons/clock-edge-app.svg | Adds an icon asset for the standalone Clock app reference. |
| edge-apps/clock/README.md | Replaces the in-repo documentation with a redirect/migration notice. |
| edge-apps/clock/tsconfig.json | Removes Clock app TypeScript configuration. |
| edge-apps/clock/package.json | Removes Clock app package scripts/dependencies from the monorepo. |
| edge-apps/clock/bun.lock | Removes Clock app lockfile from the monorepo. |
| edge-apps/clock/index.html | Removes the Clock app HTML shell. |
| edge-apps/clock/src/main.ts | Removes the Clock app runtime entrypoint. |
| edge-apps/clock/src/time.ts | Removes the Clock time formatting module. |
| edge-apps/clock/src/time.test.ts | Removes Clock time unit tests. |
| edge-apps/clock/src/weather.ts | Removes the Clock weather data module. |
| edge-apps/clock/src/weather.test.ts | Removes Clock weather unit tests. |
| edge-apps/clock/src/css/style.css | Removes Clock application styles. |
| edge-apps/clock/e2e/screenshots.spec.ts | Removes Clock screenshot e2e test. |
| edge-apps/clock/e2e/weather-mocks.ts | Removes Clock screenshot weather mock fixtures. |
| edge-apps/clock/screenly.yml | Removes Clock production manifest. |
| edge-apps/clock/screenly_qc.yml | Removes Clock QC manifest. |
| edge-apps/clock/.ignore | Removes Clock app ignore file. |
| edge-apps/clock/.gitignore | Removes Clock app gitignore file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Persistent review updated to latest commit 3be901d |
PR Code Suggestions ✨No code suggestions found for the PR. |
|
Persistent review updated to latest commit 3be901d |
PR Code Suggestions ✨No code suggestions found for the PR. |
User description
Removes source files from
edge-apps/clockand redirects to Screenly/clock-edge-app. Closes #823.PR Type
Other, Documentation
Description
Migrate clock app out of monorepo
Redirect users to standalone repository
Remove clock source, tests, manifests
Prevent CI unmatched formatting failures
Diagram Walkthrough
File Walkthrough
4 files
Remove clock screenshot end-to-end testsRemove weather mocks for screenshotsRemove time formatting unit testsRemove weather data unit tests5 files
Remove clock application entrypointRemove clock time formatting moduleRemove clock weather integration moduleRemove clock application stylesheetRemove clock app HTML shell5 files
Ignore unmatched prettier file patternsRemove clock app ignore fileRemove production clock manifestRemove QC clock manifestRemove clock TypeScript configuration2 files
Link clock app standalone repositoryReplace documentation with redirect notice1 files
Remove clock app package configuration11 files