Skip to content

chore: migrate clock app to standalone repo#845

Merged
nicomiguelino merged 3 commits into
masterfrom
chore/remove-clock-app
Jun 19, 2026
Merged

chore: migrate clock app to standalone repo#845
nicomiguelino merged 3 commits into
masterfrom
chore/remove-clock-app

Conversation

@nicomiguelino

@nicomiguelino nicomiguelino commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

User description

Removes source files from edge-apps/clock and redirects to Screenly/clock-edge-app. Closes #823.


PR Type

Other, Documentation


Description

  • Migrate clock app out of monorepo

  • Redirect users to standalone repository

  • Remove clock source, tests, manifests

  • Prevent CI unmatched formatting failures


Diagram Walkthrough

flowchart LR
  A["Playground clock app"]
  B["Screenly/clock-edge-app"]
  C["README redirects"]
  D["CI formatting check"]
  A -- "source removed" --> B
  C -- "links users" --> B
  D -- "ignores unmatched app globs" --> A
Loading

File Walkthrough

Relevant files
Tests
4 files
screenshots.spec.ts
Remove clock screenshot end-to-end tests                                 
+0/-50   
weather-mocks.ts
Remove weather mocks for screenshots                                         
+0/-71   
time.test.ts
Remove time formatting unit tests                                               
+0/-89   
weather.test.ts
Remove weather data unit tests                                                     
+0/-137 
Miscellaneous
5 files
main.ts
Remove clock application entrypoint                                           
+0/-142 
time.ts
Remove clock time formatting module                                           
+0/-37   
weather.ts
Remove clock weather integration module                                   
+0/-36   
style.css
Remove clock application stylesheet                                           
+0/-162 
index.html
Remove clock app HTML shell                                                           
+0/-42   
Configuration changes
5 files
edge-app-checks.yml
Ignore unmatched prettier file patterns                                   
+1/-0     
.ignore
Remove clock app ignore file                                                         
+0/-1     
screenly.yml
Remove production clock manifest                                                 
+0/-71   
screenly_qc.yml
Remove QC clock manifest                                                                 
+0/-71   
tsconfig.json
Remove clock TypeScript configuration                                       
+0/-8     
Documentation
2 files
README.md
Link clock app standalone repository                                         
+1/-1     
README.md
Replace documentation with redirect notice                             
+2/-52   
Dependencies
1 files
package.json
Remove clock app package configuration                                     
+0/-36   
Additional files
11 files
1080x1920.webp [link]   
1280x720.webp [link]   
1920x1080.webp [link]   
2160x3840.webp [link]   
2160x4096.webp [link]   
3840x2160.webp [link]   
4096x2160.webp [link]   
480x800.webp [link]   
720x1280.webp [link]   
800x480.webp [link]   
bg.webp [link]   

- remove source files from edge-apps/clock
- add redirect notice in edge-apps/clock/README.md
- relocate icon to edge-apps/icons/clock-edge-app.svg
- update README.md to link to Screenly/clock-edge-app
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

PR Reviewer Guide 🔍

(Review updated until commit 3be901d)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

823 - PR Code Verified

Compliant requirements:

  • Migrate edge-apps/clock out of the Playground monorepo.
  • Point users to the standalone repository at Screenly/clock-edge-app.
  • Use clock-edge-app as the target repository name.

Requires further human verification:

  • Confirm the standalone Screenly/clock-edge-app repository contains the migrated app contents as expected.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the Clock Edge App out of the Playground monorepo by removing the in-repo Clock implementation and updating documentation to point to the new standalone repository (Screenly/clock-edge-app).

Changes:

  • Removed the Clock app source code, tests, and app-specific configuration/manifests from edge-apps/clock.
  • Replaced the Clock app README with a migration notice linking to the standalone repo.
  • Updated the root README Clock app link and added a Clock icon under edge-apps/icons.

Reviewed changes

Copilot reviewed 17 out of 31 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Updates the Clock App entry to point to the standalone repository.
edge-apps/icons/clock-edge-app.svg Adds an icon asset for the standalone Clock app reference.
edge-apps/clock/README.md Replaces the in-repo documentation with a redirect/migration notice.
edge-apps/clock/tsconfig.json Removes Clock app TypeScript configuration.
edge-apps/clock/package.json Removes Clock app package scripts/dependencies from the monorepo.
edge-apps/clock/bun.lock Removes Clock app lockfile from the monorepo.
edge-apps/clock/index.html Removes the Clock app HTML shell.
edge-apps/clock/src/main.ts Removes the Clock app runtime entrypoint.
edge-apps/clock/src/time.ts Removes the Clock time formatting module.
edge-apps/clock/src/time.test.ts Removes Clock time unit tests.
edge-apps/clock/src/weather.ts Removes the Clock weather data module.
edge-apps/clock/src/weather.test.ts Removes Clock weather unit tests.
edge-apps/clock/src/css/style.css Removes Clock application styles.
edge-apps/clock/e2e/screenshots.spec.ts Removes Clock screenshot e2e test.
edge-apps/clock/e2e/weather-mocks.ts Removes Clock screenshot weather mock fixtures.
edge-apps/clock/screenly.yml Removes Clock production manifest.
edge-apps/clock/screenly_qc.yml Removes Clock QC manifest.
edge-apps/clock/.ignore Removes Clock app ignore file.
edge-apps/clock/.gitignore Removes Clock app gitignore file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nicomiguelino nicomiguelino marked this pull request as ready for review June 19, 2026 02:48
@nicomiguelino nicomiguelino requested a review from Copilot June 19, 2026 02:48
@nicomiguelino nicomiguelino marked this pull request as draft June 19, 2026 02:48
@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit 3be901d

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 32 changed files in this pull request and generated no new comments.

@nicomiguelino nicomiguelino marked this pull request as ready for review June 19, 2026 02:57
@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit 3be901d

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@nicomiguelino nicomiguelino merged commit 5e6a382 into master Jun 19, 2026
5 checks passed
@nicomiguelino nicomiguelino deleted the chore/remove-clock-app branch June 19, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: migrate edge-apps/clock to standalone repo (Screenly/clock-edge-app)

3 participants