Skip to content

fix: report email sending should not block Slack msg report - #267

Open
cirex-web wants to merge 3 commits into
mainfrom
staging
Open

fix: report email sending should not block Slack msg report#267
cirex-web wants to merge 3 commits into
mainfrom
staging

Conversation

@cirex-web

@cirex-web cirex-web commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

email sending for user reports is currently broken but we should still be able to get notified on slack

Copilot AI lite review requested due to automatic review settings August 26, 2026 23:34
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 44f707d9-2790-4b82-b7e3-9cdc4d6096cb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 82.69% 478 / 578
🔵 Statements 81.9% 498 / 608
🔵 Functions 80% 128 / 160
🔵 Branches 72.42% 260 / 359
File CoverageNo changed files found.
Generated in workflow #531 for commit 345ffd9 by the Vitest Coverage Report Action

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the /report endpoint flow so that reporting triggers Slack notifications and email sending, aiming to ensure Slack reporting isn’t delayed by email delivery.

Changes:

  • Reformats and slightly restructures the /report endpoint’s DB lookup and error handling formatting.
  • Refactors the previous createReport helper into _sendEmail, adding Slack notification on email-send failure.
  • Moves Slack notification logic into the main /report handler and includes “emailed users” in the Slack message.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/endpoints/misc.ts
Comment on lines +89 to +92
const emailedUsers = await _sendEmail({
locationName,
message,
});
Comment thread src/endpoints/misc.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants