Skip to content

test: restore env vars after tests - #137

Merged
chawyehsu merged 1 commit into
ScoopInstaller:masterfrom
chawyehsu:push-rypomykupxov
Aug 27, 2026
Merged

test: restore env vars after tests#137
chawyehsu merged 1 commit into
ScoopInstaller:masterfrom
chawyehsu:push-rypomykupxov

Conversation

@chawyehsu

@chawyehsu chawyehsu commented Aug 27, 2026

Copy link
Copy Markdown
Member

#136 follow up. Ensured environment variables that were initially unset are removed after testing.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c408bef6-8bb8-43d8-b125-e781212ba454

📥 Commits

Reviewing files that changed from the base of the PR and between c486f6e and 2241f2d.

📒 Files selected for processing (1)
  • test/install.Tests.ps1

Summary by CodeRabbit

  • Tests
    • Improved test environment cleanup by restoring original environment variable values after tests complete.
    • Ensured environment variables that were initially unset are removed after testing.
    • Reduced the risk of test-related environment settings affecting subsequent commands or test runs.

Walkthrough

The install tests now preserve the original SCOOP and SCOOP_GLOBAL environment variables and restore or remove them after the test run.

Changes

Test environment cleanup

Layer / File(s) Summary
Preserve and restore test environment variables
test/install.Tests.ps1
BeforeAll captures the original SCOOP and SCOOP_GLOBAL values. AfterAll restores them or removes them when they were not previously set.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description identifies this pull request as a follow-up to PR #136, but it does not describe the environment-variable restoration change. Add a short description of the test changes, including that the original SCOOP and SCOOP_GLOBAL values are restored after tests.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: restoring environment variables after tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 81e60bac-3e58-47d8-97c3-a890589a4cdc

📥 Commits

Reviewing files that changed from the base of the PR and between a621092 and c486f6e.

📒 Files selected for processing (1)
  • test/install.Tests.ps1

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread test/install.Tests.ps1 Outdated
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
@chawyehsu
chawyehsu merged commit 395043c into ScoopInstaller:master Aug 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant