feat: support reusing existing scoop install - #94
Conversation
|
Warning Review limit reached
Next review available in: 47 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
Walkthrough
ChangesScoop installation recovery
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: cf719328-f33e-46a9-a029-a01883073780
📒 Files selected for processing (1)
src/Scoop.psm1
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
1b5d7a2 to
f4bc789
Compare
|
@ScoopInstaller/maintainers This would be the last piece of improvements from me that are going to be part of the #84 release. If no one else plans to have further improvements into v3.0.0, I think it is time to freeze changes and move on #89. Although I am inclined to have this change since it undoubtedly improves execution performance Excavator, I still have some reservations about it, primarily due to the security risks mentioned above. It ultimately depends on how it is used though. |
|
I'm fine with it. No other changes. ed. Use |
Caution
Notice risks (cache poisoning) of sharing caches between workflows involving different trust levels:
https://docs.github.com/en/actions/reference/workflows-and-actions/dependency-caching#cache-access-for-low-trust-workflow-triggers
In scenarios involving Scoop installations, the following items exist that could potentially lead to the leakage of sensitive data:
gh_token,virustotal_api_key, andprivate_hostspersistdirectory, such as user data stored by any appappsdirectory, such as data stored by any appcachedirectory, such as cached private application packagesWhether or not to enable caching for Scoop installations is entirely up to the caller, who must understand the security model and risks described above and review data boundaries.
Example combining with
actions/cache