Skip to content

Build the API references from net10.0 - #1462

Merged
martindevans merged 1 commit into
SciSharp:masterfrom
Laurianti:fix-api-references-net10
Oct 16, 2026
Merged

martindevans merged 1 commit into
SciSharp:masterfrom
Laurianti:fix-api-references-net10

Conversation

@Laurianti

@Laurianti Laurianti commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Since #1453 the docs reach master through a bot pull request (#1455). After #1457 moved LLamaSharp.csproj to netstandard2.0;net10.0, the job fails (run 38651797784):

cd: LLama/bin/Debug/net8.0: No such file or directory

This builds the docs from net10.0 and installs only the .NET 10 SDK.

Tested in a private copy of the repository with master at 2a6a369: the job fails before this change, and generates and commits the docs after it.

Copilot AI balanced review requested due to automatic review settings October 16, 2026 13:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both workflow changes match the project’s target framework and resolve the documented directory failure without identified blocking issues.

0 open findings

What changed in this PR

Aligns API reference generation with the .NET 10 migration in #1457, fixing the missing build-output directory failure.

Changes:

  • Generate documentation from LLama/bin/Debug/net10.0.
  • Remove the unnecessary .NET 8 SDK installation.
File Description
.github/​workflows/​update_api_references.yml Updates SDK installation and documentation input path to .NET 10.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@martindevans

Copy link
Copy Markdown
Member

Thanks for fixing this 👍

@martindevans
martindevans merged commit 63cb8c7 into SciSharp:master Oct 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants