Skip to content

Chris/schy 380 sdk entitlement usage does not update from datastream#153

Merged
cbrady merged 4 commits into
mainfrom
chris/schy-380-sdk-entitlement-usage-does-not-update-from-datastream
May 29, 2026
Merged

Chris/schy 380 sdk entitlement usage does not update from datastream#153
cbrady merged 4 commits into
mainfrom
chris/schy-380-sdk-entitlement-usage-does-not-update-from-datastream

Conversation

@cbrady

@cbrady cbrady commented May 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@cbrady cbrady self-assigned this May 22, 2026
@cbrady cbrady requested a review from a team as a code owner May 22, 2026 14:59
public partial class ClientOptions
{
public Dictionary<string, bool> FlagDefaults { get; set; } = new Dictionary<string, bool>();
public ISchematicLogger Logger { get; set; } = new ConsoleLogger();

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OpenFeature implementation reads this directly rather than falling back as the main client does (_logger = _options.Logger ?? new ConsoleLogger(_options.LogLevel). So we should check if there's a logging regression for anyone using OpenFeature

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, there was a regression. fixed and added a test.

@cbrady cbrady requested a review from bpapillon May 29, 2026 14:57
@cbrady cbrady merged commit 25f2e61 into main May 29, 2026
4 checks passed
@cbrady cbrady deleted the chris/schy-380-sdk-entitlement-usage-does-not-update-from-datastream branch May 29, 2026 18:40
fern-api Bot added a commit that referenced this pull request Jun 8, 2026
Patches absorbed by generator (2):
  - patch-25f2e612: Chris/schy 380 sdk entitlement usage does not update from datastream (#153)
  - patch-f26b067f: chore: update rules engine WASM to v0.3.0 (#156)
    The generator now produces these customizations natively.
cbrady pushed a commit that referenced this pull request Jun 8, 2026
* [fern-generated] Update SDK

Generated by Fern
CLI Version: unknown
Generators:
  - fernapi/fern-csharp-sdk: 2.66.8

* [fern-replay] Applied customizations

Patches absorbed by generator (2):
  - patch-25f2e612: Chris/schy 380 sdk entitlement usage does not update from datastream (#153)
  - patch-f26b067f: chore: update rules engine WASM to v0.3.0 (#156)
    The generator now produces these customizations natively.

---------

Co-authored-by: fern-api <115122769+fern-api[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants