Conversation
A nullable number as the map value does not survive SDKs that strip null map values or generators that type the value as non-nullable, so an unbounded grant read as off. Presence of the key is now the opt-in and the overdraft limit is an optional member of the value.
SDKs that strip null map values already read {"cred_1": null} as off, so
the engine drops the entry too and a malformed payload fails closed.
schematic-bot
approved these changes
Sep 11, 2026
bpapillon
deleted the
bpapillon/schx-778-credit_postpaid_limit-pick-a-wire-shape-that-survives
branch
September 11, 2026 17:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
credit_postpaid_limit(credit ID to a nullable number) withcredit_postpaid(credit ID to{"overdraft_limit"?: number}). Node, Python and Ruby strip null map values before calling WASM, and typed generators collapse a nullable map value, so an unlimited grant read as off.A credit's presence in the map turns postpaid on, and a missing or null
overdraft_limitmeans no limit. Null always reads as absent: a null map is empty, a null credit entry is dropped (off, as the null-stripping SDKs already read it), and a null limit is no limit.CreditPostpaidMap.UnmarshalJSONdrops the null entries. Evaluation is unchanged. Nothing released reads the old field, so it goes without an alias.schematic-api needs a v0.1.24 tag of this before its matching PR merges.