✨ Add apps, geo, and countries lookup commands (v5 Phase 1)#33
Merged
Conversation
Surface three read-only v5 reference resources from asa-api-client that the CLI previously could not reach: - asa apps search <query> — find advertisable apps and their adamId - asa geo search <query> -c — find geo locations for campaign targeting - asa countries list — list supported countries and ad languages All support --format table/json/csv. Phase 1 of #32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of #32 — surfaces three read-only lookup resources from the
asa-api-clientv5 surface that the CLI previously had no way to reach. These are the foundational lookups: you need an app'sadamIdto create campaigns, and geo ids to target locations.New commands
asa apps search <query> [--own] [--limit]client.apps.searchadamIdasa geo search <query> --country US [--entity] [--limit]client.geo.searchasa countries list [--code US ...]client.countries_or_regions.listAll three support
--format table\|json\|csvvia the sharedoutput_datahelper and follow the existing typer/utilsconventions (get_client,spinner,handle_api_error).Verification
ruff check/ruff format --checkmypy --strict(16 source files)pytest— 8 passed (added help/registration tests for the 3 new groups)Scope
Part of #32 — does not close it. Remaining phases: creative management (
ads,product-pages), reporting & billing (custom-reports,budget-orders), and org/access (acls).