Skip to content

Add gif functionality using klipy#970

Open
nikiwastaken wants to merge 2 commits into
SableClient:devfrom
nikiwastaken:feat/gif-support
Open

Add gif functionality using klipy#970
nikiwastaken wants to merge 2 commits into
SableClient:devfrom
nikiwastaken:feat/gif-support

Conversation

@nikiwastaken

Copy link
Copy Markdown
Contributor

Description

Based on work in #677.

Gif search functionality using klipy. Set your api token in config.json, also requires a mxc proxy. Favoriting gifs works by using account data.

Fixes #60

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

I did not use AI for my changes. To quote the original PR:

The changes to renderItem() to support GIFs were AI generated. It returns GIF Items and ensures they are scaled properly.

Those seem sane.

@nikiwastaken nikiwastaken requested review from 7w1 and hazre as code owners June 21, 2026 13:22
@nikiwastaken

Copy link
Copy Markdown
Contributor Author

I am not particularly sure about having the favorites button in two different places. The actual logic is similar but distinct enough that splitting it off into a separate component is also awkward.

@7w1 7w1 mentioned this pull request Jun 21, 2026
11 tasks
7w1 added a commit that referenced this pull request Jun 21, 2026
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->

Cherry picked from #970 

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GIF Search

1 participant