Skip to content

Verify recorded controller traces offline - #54

Merged
SYMBaiEX merged 2 commits into
mainfrom
feat/cycle7-issue42
Oct 5, 2026
Merged

SYMBaiEX merged 2 commits into
mainfrom
feat/cycle7-issue42

Conversation

@SYMBaiEX

@SYMBaiEX SYMBaiEX commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Add opencontroller replay verify <events.jsonl> for offline verification at each recorded command boundary.
  • Compare deterministic input-control fields only; report mismatches by one-based event and line, and label unsupported or legacy command events unverifiable.
  • Validate timestamps and required fields on recognized replay events, including non-command events, before skipping them.
  • Document verifier limits and add timed press/release, mismatch, malformed JSON/event, legacy, and unsupported fixtures.

Validation on final head c0e2c44af3711d3cdf3a3081a3194a528ba746be

  • CLI suite: 40 passed.
  • Root typecheck and build passed.
  • Targeted Biome check passed.
  • Built CLI checks passed for a timed trace, a mismatch, and malformed input.
  • GitHub CI test and CodeRabbit statuses passed; independent exact-head review found no blocker. The review noted additional malformed timestamp/feedback/error/annotation test cases could improve coverage.

Closes #42

Copilot AI balanced review requested due to automatic review settings October 5, 2026 00:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 44 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d683c0f6-09b1-472a-bc9e-dee89dd63c81
📥 Commits

Reviewing files that changed from the base of the PR and between c7b744e and c0e2c44.

📒 Files selected for processing (10)
  • docs/replay-logs.md
  • packages/cli/src/__tests__/fixtures/replay-verify-legacy.jsonl
  • packages/cli/src/__tests__/fixtures/replay-verify-malformed-state-event.jsonl
  • packages/cli/src/__tests__/fixtures/replay-verify-malformed.jsonl
  • packages/cli/src/__tests__/fixtures/replay-verify-mismatch.jsonl
  • packages/cli/src/__tests__/fixtures/replay-verify-timed.jsonl
  • packages/cli/src/__tests__/fixtures/replay-verify-unsupported.jsonl
  • packages/cli/src/__tests__/replay-verify.test.ts
  • packages/cli/src/commands/replay-verify.ts
  • packages/cli/src/index.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SYMBaiEX
SYMBaiEX force-pushed the feat/cycle7-issue42 branch from 1fedbd7 to 8ab2dcc Compare October 5, 2026 00:50
@SYMBaiEX
SYMBaiEX force-pushed the feat/cycle7-issue42 branch from 8ab2dcc to c0e2c44 Compare October 5, 2026 00:56
@SYMBaiEX
SYMBaiEX merged commit b7b6995 into main Oct 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify recorded controller traces offline

3 participants