Repository navigation
[5/10] Harden the macOS loader and launcher - #368
Merged
netniV merged 2 commits intoNov 14, 2026
Merged
Conversation
added 2 commits
October 15, 2026 16:40
The loader kept a pointer into an autoreleased string, ignored a missing settings file or game path, then executed a relative path. Each case now fails with a message on stderr. Symlinks are resolved, so launching through a link no longer injects a dylib path that does not exist.
The launcher uses the Xsolla updater directly and drops unused view state. Required entitlements are compared without redundant reapplication flags, and UI work stays on the main actor. The rsync bridge owns its patch handles and reports read, write, patch and close failures instead of dropping them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 5 of 10 · base
refactor/04-features-settings-sync· 2 commitsThe macOS loader could keep going with a bad path or a dangling string and then run the wrong thing, quietly. This PR makes both the loader and the launcher stop with a readable message instead.
What changes
Behavior changes
Testing
Built with xmake. Every commit was built on macOS arm64. Nothing was run in the game.