Repository navigation
[1/10] Update vendored SPUD to current upstream - #364
Merged
Merged
Conversation
Replace the vendored snapshot with the current upstream detour, relocation and signature-scanning code. Callers and the x64 fixture move to the new install API, which reports failures instead of returning a bare pointer. The upstream CMake manifests and license stay unchanged, so dependency provenance can still be checked directly. The chat title hooks go back to SetWidgetData and OnDidBindContext, on Windows too. The new SPUD patches fit the shared title wrapper, so neither the SetIdentifiers workaround nor the Windows skip is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 10 · base
dev· 1 commitThe vendored SPUD snapshot is behind upstream, and its install call reports failure poorly. This PR replaces the snapshot with current upstream detour, relocation, and signature-scanning code so later hook work builds on the newer API.
What changes
xmake-packages/packages/s/spud/spud-src/is replaced. Upstream CMake manifests and the license file stay unchanged, so provenance can still be checked against upstream.SetWidgetDataandOnDidBindContext, on Windows too. The new SPUD patches fit the shared title wrapper, so neither theSetIdentifiersworkaround nor the Windows skip is needed.Testing
Built with xmake. The commit was built on macOS arm64. Nothing was run in the game.