Repository navigation
Separate System and Galaxy pan speeds - #362
Draft
Guffawaffle wants to merge 6 commits into
Draft
Guffawaffle wants to merge 6 commits into
Guffawaffle wants to merge 6 commits into
Conversation
This was referenced Nov 13, 2026
Guffawaffle
changed the title
netniV
requested changes
Nov 14, 2026
Comment on lines
617
to
+627
| if (control.enable_experimental) | ||
| r.Read("graphics", "system_pan_momentum", g.system_pan_momentum); | ||
| r.Read("graphics", "system_pan_momentum_falloff", g.system_pan_momentum_falloff); | ||
| r.ReadValid("graphics", "system_pan_momentum_falloff", g.system_pan_momentum_falloff, | ||
| [](float v) { return std::isfinite(v); }); | ||
| const auto bounded_falloff = std::clamp(g.system_pan_momentum_falloff, 0.0f, 0.99f); | ||
| if (g.system_pan_momentum_falloff != bounded_falloff) { | ||
| spdlog::warn("config graphics.system_pan_momentum_falloff: '{}' clamped to {}", g.system_pan_momentum_falloff, | ||
| bounded_falloff); | ||
| g.system_pan_momentum_falloff = bounded_falloff; | ||
| r.Record("graphics", "system_pan_momentum_falloff", bounded_falloff); | ||
| } |
Collaborator
There was a problem hiding this comment.
One part is marked Experimental, which means it won't take effect where the rest does? This seems inconsistent to me. Either we should make it all experimental or none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add independent
graphics.system_pan_speedandgraphics.galaxy_pan_speedmultipliers for mouse/touch and keyboard panning. Both default to1.0. Each pan controller selects its own setting, so a faster Galaxy view leaves System panning unchanged. The existingsystem_pan_speedkey now affects System view only.Apply the configured glide falloff once in both native and mod hotkey modes, preserve recognizer-owned dragging, and retain effective movement for subsequent glide. Limit
system_pan_momentum_falloffto0…0.99so saved values cannot sustain or accelerate a glide. These controls work without experimental mode; the unused legacy momentum key remains readable for compatibility.Pan speeds accept
0.1–10; zero and smaller values fall back to normal speed (1.0).