chore: bump version to 1.16.1#132
Merged
Merged
Conversation
WindIO auto-RNA rotor-inertia fix (#130) plus the angle_units control and one/two-bladed guard that came out of review.
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the WindIO auto-RNA rotor-inertia fix (#130) and the review follow-ups to a 1.16.1 patch release.
Summary
versionto 1.16.1 acrosspyproject.toml,__init__.pyandCITATION.cff, and promotes the[Unreleased]CHANGELOG block to[1.16.1].What ships in 1.16.1
The auto-RNA (
read_windio_rna/lumped_rna_cal=True) now assembles the rotor as a rigid body carrying the diametral inertia from the spanwise blade mass, which the previous point-mass-at-apex lump dropped (~2.5x the value on IEA-22). It is placed at its true coned centre of mass before the parallel-axis shift, with the lever folding in the coned hub radius(hub_radius + span)*cos(cone)(matching WISDEM/ElastoDyn), prebend and sweep, and the span measured from the blade root. Off-diagonal hub inertia is rotated with the correct WindIO hub-frame handedness.Also adds an
angle_unitscontrol ("auto"/"rad"/"deg", forwarded asrna_angle_units) to reconcile the WindIO rad/deg schema-vs-file ambiguity, and rejects one- and two-bladed rotors (whose transverse inertia a single rigid lump cannot represent) with a clear error.Total RNA mass is unchanged; the inertia and, for coned rotors, the centre of mass change relative to 1.16.0.