Skip to content

fix(ci): restrict manual publish workflow execution to version branches#339

Draft
twisti-dev wants to merge 2 commits into
version/26.1from
codex/fix-arbitrary-code-execution-in-publish-workflow
Draft

fix(ci): restrict manual publish workflow execution to version branches#339
twisti-dev wants to merge 2 commits into
version/26.1from
codex/fix-arbitrary-code-execution-in-publish-workflow

Conversation

@twisti-dev
Copy link
Copy Markdown
Contributor

Motivation

  • Prevent exposure of publishing credentials and execution of repository-controlled build/publish code via workflow_dispatch by ensuring manual runs only execute against release branches.

Description

  • Add a job-level guard in .github/workflows/publish.yml: if: github.event_name != 'workflow_dispatch' || startsWith(github.ref, 'refs/heads/version/') so manually-dispatched runs only proceed when the selected ref is a version/* branch while preserving existing push-trigger behavior.

Testing

  • Programmatically inspected the updated .github/workflows/publish.yml and confirmed the diff contains only the single if: guard addition and the workflow still triggers on push to version/* branches.

Codex Task

@twisti-dev twisti-dev force-pushed the codex/fix-arbitrary-code-execution-in-publish-workflow branch 2 times, most recently from 0cf4a0a to 2766971 Compare May 17, 2026 22:17
@twisti-dev twisti-dev force-pushed the codex/fix-arbitrary-code-execution-in-publish-workflow branch 2 times, most recently from e7212e1 to c45fe0c Compare May 27, 2026 12:30
@twisti-dev twisti-dev force-pushed the codex/fix-arbitrary-code-execution-in-publish-workflow branch from c45fe0c to bc5cb5f Compare May 27, 2026 19:24
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ API/ABI changes detected!

This PR contains changes that modified the public API. To update the reference ABI dumps:

./gradlew updateKotlinAbi
git add **/api/**
git commit -m "Update ABI reference"
git push

After updating, the CI will pass. Make sure the changes are backward compatible.

@mergify mergify Bot added the conflict label May 27, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 27, 2026

👋 twisti-dev your PR is conflicting and needs to be updated to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant