Repository navigation
Conversation
… the sandbox - Pass --no-git-ignore on every openshell sandbox upload (room/project refresh, full and view-only uploads, brokered-secret placeholders). The CLI otherwise applies .gitignore when the source sits in a git work tree, which left rooms and other ignored paths empty in the sandbox. - A sandboxed Python process cannot read the host insight folder, so the engine-query worker now writes the a_*.json result to a temp file, pushes it to /tmp/semoss-engine-results in the sandbox, and returns that path. Non-sandbox runs are unchanged.
2 of 5 tasks
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openshell sandbox uploadapplied.gitignorewhen the source sat inside a git work tree, failing with "Git filtering selected no files" and leaving rooms empty in the sandbox. Every upload now passes--no-git-ignore(room/project refresh, full and view-only uploads, brokered-secret placeholders).a_*.json) were unreachable (FileNotFoundError).NativePyEngineWorkernow writes the result to a temp file, pushes it into/tmp/semoss-engine-resultsin the sandbox, and returns that path. Non-sandbox behavior is unchanged.ClientProcessWrappergetsisOpenShell()anddeliverResultFile();OpenShellTransport.pushScratchFile()validates the file name (a_<6 chars>.json, regular file, no symlink) before uploading. The scratch folder is never watched, so it does not trigger write-back.Test plan
/tmp/semoss-engine-resultsempty after runs and no newa_*.jsonleft in the room folder