Skip to content

featg: hash session ids where they are written out, and version smss edits - #3350

Merged
themaherkhalil merged 1 commit into
devfrom
feat/hashed-session-ids-and-smss-edit-check
Nov 19, 2026
Merged

themaherkhalil merged 1 commit into
devfrom
feat/hashed-session-ids-and-smss-edit-check

Conversation

@themaherkhalil

Copy link
Copy Markdown
Collaborator

Session ids

  • Add SessionIds.hash: an HMAC-SHA256 keyed by the RDF_Map setting LOG_HASH_SALT, or a plain SHA-256 when the setting is not there. Placeholders such as UNKNOWN pass through unchanged.
  • Use it for the insight cache folder, agent room insight ids, the natural language search R tables, user tracking login and logout, the inference log messages, the audit trail session hash and the OpenShell lease registry.
  • The log context holds the hash, so the audit trail takes it as already hashed, and InsightHandle and the automation run read the session only from ThreadStore.
  • Auth-only share tokens store no session value.
  • The headless Chrome utilities log cookie names only.

Smss edits

  • Add SmssEditCopy. It reads an smss with its secret store values, conceals them, and hashes the file bytes plus the secrets sorted by key as smssHash.
  • The engine, project, database and admin smss read reactors return { smss, smssHash } and gain reactor definitions.
  • SmssEditCopy.requireCurrent refuses a save with no hash and throws the new ContentChangedException (SMSS_CHANGED) for a stale one.
  • Docs: a session ids section in authentication_and_authorization, and the smss editing flow in secret_settings.

…edits

Session ids
- Add SessionIds.hash: an HMAC-SHA256 keyed by the RDF_Map setting
  LOG_HASH_SALT, or a plain SHA-256 when the setting is not there.
  Placeholders such as UNKNOWN pass through unchanged.
- Use it for the insight cache folder, agent room insight ids, the
  natural language search R tables, user tracking login and logout,
  the inference log messages, the audit trail session hash and the
  OpenShell lease registry.
- The log context holds the hash, so the audit trail takes it as
  already hashed, and InsightHandle and the automation run read the
  session only from ThreadStore.
- Auth-only share tokens store no session value.
- The headless Chrome utilities log cookie names only.

Smss edits
- Add SmssEditCopy. It reads an smss with its secret store values,
  conceals them, and hashes the file bytes plus the secrets sorted by
  key as smssHash.
- The engine, project, database and admin smss read reactors return
  { smss, smssHash } and gain reactor definitions.
- SmssEditCopy.requireCurrent refuses a save with no hash and throws
  the new ContentChangedException (SMSS_CHANGED) for a stale one.
- Docs: a session ids section in authentication_and_authorization,
  and the smss editing flow in secret_settings.
@themaherkhalil
themaherkhalil requested a review from a team as a code owner November 19, 2026 13:54
@snyk-io

snyk-io Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@themaherkhalil
themaherkhalil merged commit cea58a7 into dev Nov 19, 2026
5 checks passed
@themaherkhalil
themaherkhalil deleted the feat/hashed-session-ids-and-smss-edit-check branch November 19, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant