Repository navigation
fix(sandbox): percolate no-net param to inform seccomp block - #3348
Merged
Merged
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
SANDBOX_MODE=NAMESPACEit was observed that, regardless of the presence/omission of--no-netargument, the sandbox_launcher.py blocked network access to user processes. It was desired to conditionally allow such network access.Changes Made
Forward the
no-netparameter state further into the launcher's handlers to not restrict_inet when present.How to Test
Enable
SANDBOX_MODE=NAMESPACEandSANDBOX_ALLOW_NETWORK=TRUE, attempt to run a python request to a network resource (e.g.import requests;requests.get("https://google.com");), confirm<Response [200]>instead ofFailed to resolve 'google.com' ([Errno - 2] Name or service not known)