Repository navigation
feat: require the current smss hash on save, and log the session hash - #488
Merged
Merged
Conversation
themaherkhalil
commented
Nov 19, 2026
Collaborator
- The engine, project and admin smss save endpoints take smssHash and check it while holding the engine or project lock. A stale hash answers 409 with errorCode SMSS_CHANGED, a missing hash answers 400, and a successful save returns the new hash.
- ResourceUtility maps ContentChangedException to 409 with errorMessage and errorCode.
- The log4j sessionId context and the MCP reaper log carry SessionIds.hash.
- The engine, project and admin smss save endpoints take smssHash and check it while holding the engine or project lock. A stale hash answers 409 with errorCode SMSS_CHANGED, a missing hash answers 400, and a successful save returns the new hash. - ResourceUtility maps ContentChangedException to 409 with errorMessage and errorCode. - The log4j sessionId context and the MCP reaper log carry SessionIds.hash.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
themaherkhalil
deleted the
feat/hashed-session-ids-and-smss-edit-check
branch
November 19, 2026 14:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.