Skip to content

feat: require the current smss hash on save, and log the session hash - #488

Merged
themaherkhalil merged 1 commit into
devfrom
feat/hashed-session-ids-and-smss-edit-check
Nov 19, 2026
Merged

themaherkhalil merged 1 commit into
devfrom
feat/hashed-session-ids-and-smss-edit-check

Conversation

@themaherkhalil

Copy link
Copy Markdown
Collaborator
  • The engine, project and admin smss save endpoints take smssHash and check it while holding the engine or project lock. A stale hash answers 409 with errorCode SMSS_CHANGED, a missing hash answers 400, and a successful save returns the new hash.
  • ResourceUtility maps ContentChangedException to 409 with errorMessage and errorCode.
  • The log4j sessionId context and the MCP reaper log carry SessionIds.hash.

- The engine, project and admin smss save endpoints take smssHash and
  check it while holding the engine or project lock. A stale hash
  answers 409 with errorCode SMSS_CHANGED, a missing hash answers 400,
  and a successful save returns the new hash.
- ResourceUtility maps ContentChangedException to 409 with
  errorMessage and errorCode.
- The log4j sessionId context and the MCP reaper log carry
  SessionIds.hash.
@themaherkhalil
themaherkhalil requested a review from a team as a code owner November 19, 2026 13:57
@snyk-io

snyk-io Bot commented Nov 19, 2026

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@themaherkhalil
themaherkhalil merged commit 3dc2e38 into dev Nov 19, 2026
6 checks passed
@themaherkhalil
themaherkhalil deleted the feat/hashed-session-ids-and-smss-edit-check branch November 19, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant