Repository navigation
feat: openshell user sandbox - #484
Merged
Merged
Conversation
…active Every authenticated request refreshes the user's sandbox lease (at most once a minute per session, for the session timeout). A session ending releases its lease; the sandbox goes when the user's last session does, rather than with whichever session happened to start it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sessionDestroyed also fires when Tomcat stops. Treat only a logout or an idle timeout as the session being over; otherwise keep the sandbox lease and do not clear the insight's python variables, which live on in the user's worker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…onIsOver Users without a primary login keep the per-session cleanup; the expiry slack is a named constant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The filter records the sandbox owner on the session while the user is logged in; session cleanup uses it, because a provider logout has already dropped the token the owner was derived from.
…ndbox # Conflicts: # src/prerna/web/conf/NoUserInSessionFilter.java # src/prerna/web/conf/UserSessionLoader.java
…ter the dev merge
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Monolith side of the OpenShell user sandbox in SEMOSS/Semoss#3336 (replaces #461, same branch moved from a fork into this repo). With
SANDBOX_MODE=OPENSHELLeach user has one sandbox that outlives any single session. Monolith decides when a user's claim on it starts, refreshes, and ends.This calls
OpenShellUserSandboxesmethods added in SEMOSS/Semoss#3336, so merge that PR first.Changes Made
NoUserInSessionFilter: any authenticated request refreshes the user's sandbox lease (at most once a minute per session), not only Python calls. The owner is also saved on the session, because dropping a login provider can leave nothing to derive the owner from by the time the session is destroyed.UserSessionLoader: when a session ends, the user's Python worker and chroot are no longer shut down per session in OpenShell mode. The lease is released instead, and the sandbox is deleted when the user's last session anywhere ends. A server stop destroys every session but is not the user leaving, so it keeps the lease and the user's Python variables. Only a logout, an app-ended session or a real timeout ends the claim.SessionResource: sessions the app ends on purpose (logout cancel and invalidate flows) go throughendSession, which sets the newIS_SESSION_ENDEDattribute before invalidating, so cleanup treats them as over.How to Test
CHROOT_ENABLE=trueandSANDBOX_MODE=OPENSHELL, log in and run a Python cell so the sandbox exists.Notes
NoUserInSessionFiltermatchdev(CRLF).