Repository navigation
Preserve nested right-hand expressions in grouped filters - #327
Merged
phanak-sap merged 1 commit intoOct 29, 2026
Merged
Conversation
Contributor
|
Hi @UmutAlisoglu thx for quick follow-up. Yeah, exactly something like this I had in mind, to either resurface possible bug or at least have more stronger regression suite. |
phanak-sap
reviewed
Oct 29, 2026
phanak-sap
reviewed
Oct 29, 2026
phanak-sap
requested changes
Oct 29, 2026
phanak-sap
left a comment
phanak-sap
left a comment
Contributor
There was a problem hiding this comment.
thx for PR, pls just small notes, overly it is OK to merge and will go in after requested changes.
Signed-off-by: Umut Alisoglu <umutalisoglu@gmail.com>
UmutAlisoglu
force-pushed
the
codex/nested-filter-regressions
branch
from
October 29, 2026 17:53
0377a49 to
24f752e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested right-hand
Qexpressions lose conditions even whengroup=Trueis enabled. For example,Q(NameLast="Smith") & (Q(ID=1) | (Q(ID=3) & Q(NickName="Tim")))currently keeps onlyNameLastandID=1, dropping the second matching branch.Follow-up to the additional AND/OR/parenthesis coverage suggested in #324. Recursively render right-hand subtrees in the opt-in grouped mode; keep the default legacy rendering unchanged. No change to the mutable
Qoperator API or its existing restriction on reusing an initialized left operand.Four new parameterized cases cover alternating operators across multiple levels, nested OR/AND tails and three grouped filter calls. They check exact filter text, independently parsed row selections, full encoded URLs and executed mocked requests. Three nested regressions fail before the fix; all 18 grouping tests pass afterward.
Validation on Windows / Python 3.11.9:
Signed off. AI assistance was used for implementation and regression tests.