Skip to content

fix(deps): update protobuf dependency to version >=7.36.0 - #323

Merged
ArthurTonial merged 5 commits into
mainfrom
fix/protobuf-dependency
Sep 10, 2026
Merged

fix(deps): update protobuf dependency to version >=7.36.0#323
ArthurTonial merged 5 commits into
mainfrom
fix/protobuf-dependency

Conversation

@ArthurTonial

Copy link
Copy Markdown
Member

Disclaimer: Do not include SAP-internal or customer-specific information in this PR (e.g. internal system URLs, customer names, tenant IDs, or confidential configurations). This is a public repository.

Description

Bumps protobuf from >=6.33.5,<7 to >=7.36.0 to fix CVE-2026-0994 (BDSA-2025-123809).

The vulnerability allows a remote attacker to trigger a stack overflow via uncontrolled recursion in the ParseDict function. The partial fix in 6.33.5 / 6.33.6 only patched _ConvertAnyMessage(), leaving _ConvertStructMessage(), _ConvertListOrTupleValueMessage(), and _ConvertGenericMessage() exploitable. The complete fix is available only in 7.36.0+.

uv.lock updated accordingly; resolved version is 7.36.1.

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Dependency update

How to Test

  1. Run uv sync to install updated dependencies
  2. Run uv run pytest tests/ --ignore=tests/integration — all unit tests should pass
  3. Verify the installed version: uv run python -c "import google.protobuf; print(google.protobuf.__version__)" — should print 7.36.1

Checklist

Before submitting your PR, please review and check the following:

  • I have read the Contributing Guidelines
  • I have verified that my changes solve the issue
  • I have added/updated automated tests to cover my changes
  • All tests pass locally
  • I have verified that my code follows the Code Guidelines
  • I have updated documentation (if applicable)
  • I have added type hints for all public APIs
  • My code does not contain sensitive information (credentials, tokens, etc.)
  • I have followed Conventional Commits for commit messages

Breaking Changes

N/A — no breaking changes observed in tests.

Additional Notes

  • CVE-2026-0994 / BDSA-2025-123809, severity Medium 6.1
  • The only call site in this repo is MessageToDict in src/sap_cloud_sdk/core/auditlog_ng/client.py:237, which converts outbound audit log events — not user-supplied input. Risk is low, but upgrading is the correct response.
  • a2a-sdk was also bumped from 1.1.21.0.2 as a side effect of dependency resolution; verify this is acceptable.

@ArthurTonial
ArthurTonial marked this pull request as ready for review September 9, 2026 18:59
@ArthurTonial
ArthurTonial requested a review from a team as a code owner September 9, 2026 18:59
Comment thread pyproject.toml Outdated
NicoleMGomes
NicoleMGomes previously approved these changes Sep 10, 2026
@NicoleMGomes

Copy link
Copy Markdown
Contributor
WhatsApp Image 2026-08-12 at 16 28 59

@ArthurTonial
ArthurTonial merged commit 88d8db3 into main Sep 10, 2026
10 of 11 checks passed
@ArthurTonial
ArthurTonial deleted the fix/protobuf-dependency branch September 10, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants