Skip to content

chore: add pre-commit as a development dependency - #317

Merged
cassiofariasmachado merged 2 commits into
mainfrom
chore/add-pre-commit-as-dev-dependency
Sep 8, 2026
Merged

chore: add pre-commit as a development dependency#317
cassiofariasmachado merged 2 commits into
mainfrom
chore/add-pre-commit-as-dev-dependency

Conversation

@cassiofariasmachado

Copy link
Copy Markdown
Member

Disclaimer: Do not include SAP-internal or customer-specific information in this PR (e.g. internal system URLs, customer names, tenant IDs, or confidential configurations). This is a public repository.

Description

Adds pre-commit as an explicit development dependency and updates the installation instructions in the development guide to reflect this.

Related Issue

N/A

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Dependency update

How to Test

  1. Clone the repo and run uv sync --group dev
  2. Verify pre-commit is available in the environment
  3. Run pre-commit run --all-files to confirm hooks execute correctly

Checklist

Before submitting your PR, please review and check the following:

  • I have read the Contributing Guidelines
  • I have verified that my changes solve the issue
  • I have added/updated automated tests to cover my changes
  • All tests pass locally
  • I have verified that my code follows the Code Guidelines
  • I have updated documentation (if applicable)
  • I have added type hints for all public APIs
  • My code does not contain sensitive information (credentials, tokens, etc.)
  • I have followed Conventional Commits for commit messages

Breaking Changes

None.

Additional Notes

This ensures pre-commit is installed automatically when setting up the development environment with uv sync, so contributors don't need to install it separately.

@cassiofariasmachado
cassiofariasmachado marked this pull request as ready for review September 8, 2026 17:19
@cassiofariasmachado
cassiofariasmachado requested a review from a team as a code owner September 8, 2026 17:19
jplbrun
jplbrun previously approved these changes Sep 8, 2026
jeanscherf
jeanscherf previously approved these changes Sep 8, 2026
@cassiofariasmachado
cassiofariasmachado merged commit 5be187d into main Sep 8, 2026
10 of 11 checks passed
@cassiofariasmachado
cassiofariasmachado deleted the chore/add-pre-commit-as-dev-dependency branch September 8, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants