feat: Support OpenAPI 3.1.x - #1231
Merged
Merged
Conversation
CharlesDuboisSAP
left a comment
CharlesDuboisSAP
left a comment
Contributor
There was a problem hiding this comment.
Some test coverage is lacking, you could add some more unit tests
…k-java into support-openapi-3.1
ZhongpinWang
marked this pull request as ready for review
July 23, 2026 13:42
Contributor
There was a problem hiding this comment.
Overall LGTM, one small thing:
Why did you duplicate all integrations tests in DataModelGeneratorApacheIntegrationTest? I would remove them since they are already tested in DataModelGeneratorIntegrationTest, and they cover the same lines of code, apache only changes the inside of the Api class which are not the point of your tests anyway.
ZhongpinWang
changed the title
Contributor
Author
|
@CharlesDuboisSAP @Jonas-Isr Can you add a simple release note for this? I don't know how you do this normally in Java team. |
Contributor
Author
|
I added a log warning for 3.1 to point out that this is an experimental feature. We can remove this after a while. |
CharlesDuboisSAP
left a comment
CharlesDuboisSAP
left a comment
Contributor
There was a problem hiding this comment.
LGTM, let's wait for @Jonas-Isr's review
Jonas-Isr
reviewed
Aug 3, 2026
Jonas-Isr
left a comment
Jonas-Isr
left a comment
Member
There was a problem hiding this comment.
Looks good to me :)
I only had some pretty minor points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is a generated (later manually reviewed and fixed) PoC for evaluating the effort of supporting OpenAPI 3.1.x in the generator.
The following two files coming from the initial round of generation might be outdated but you can use as a reference.
I generated all data models in AI SDK Java with the new SNAPSHOT cloud sdk generator, and there were no breaking changes.
See SAP/ai-sdk-java#958 for the generated result.