fix(changeset): ignore private vscode-logging examples - #589
Merged
Merged
Conversation
The three vscode-logging example packages are private demos with no npm publish and no GitHub Release. With privatePackages.tag=true the release flow tagged them and listed them in publishedPackages, so the upload-vsix step then threw "No release found" and turned the main Release run red. Adding them to changeset ignore keeps them out of versioning and tagging, so they never enter publishedPackages and upload-vsix no longer fails. Signed-off-by: Jacob Kreyenbuehl <jacob.kreyenbuehl@sap.com>
bd82
approved these changes
Aug 26, 2026
Contributor
Build ReportPlease note:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add the three private
vscode-loggingexample packages to the Changesetsignorelist:vscode-logging-extension-example,vscode-logging-extension-wrapper-example,@vscode-logging/library-example.Why
The main
Releaseworkflow went red after the migration (#583) at the Upload VSIX to releases step withNo release found for <example>@<version>.Root cause: the examples are
privateand the config setsprivatePackages: { tag: true }, so the release flow tagged them and listed them inpublishedPackages.scripts/upload-vsix-to-releases.mjsthen iterates that list and errors when a listed package has no matching GitHub Release - the examples have none. (The.vsixattach is a separate, conditional step; the throw is purely about a published package with no matching Release.)The
Releaseworkflow only runs on push tomain, so branch CI never exercised this path.Behaviour
With the examples in
ignore, they are excluded from versioning and tagging, never enterpublishedPackages, andupload-vsixno longer fails. No changeset here, so no packages are published by this PR - it only fixes the pipeline.Shachar deleted the stale example tags on origin, so this run also serves as a live check that
ignorekeeps them from being re-tagged.