docs: add proxy_client to init_llm (harmonized model initialization) - #125
Closed
yamaceay wants to merge 4 commits into
Closed
docs: add proxy_client to init_llm (harmonized model initialization)#125yamaceay wants to merge 4 commits into
yamaceay wants to merge 4 commits into
Conversation
3 tasks
zhaoyang868686
approved these changes
Sep 8, 2026
Contributor
Author
|
In my opinion, it would be better to mark this as a bug rather than another breaking change, because this is not intended to operate that way. So, we need to revert the change of breaking changes and add a new release note saying that the bug is now fixed. |
Contributor
Author
|
Closing this PR because it should work as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
What this PR does and why it is needed
Since 7.2.0+, some breaking changes have been introduced to the API. First of all,
init_llmandinit_embedding_modelnow require the model name / id to be passed (previously it was optional). Secondly,proxy_clientis essential to perform further provider calls.Currently, in docs, no
proxy_clientis passed through. This is why, in the underlying subclass call, proxy client is forwarded as None, so that we run into the error "NoneType has no such XXX attribute / property". For this, we should always instantiate proxy client usinggen_ai_hub.proxy.core.get_proxy_client(...).So the correct fix to the docs is to add:
Same applies for embeddings.
Definition of Done