docs: Update docs in core and gen - #124
Open
yamaceay wants to merge 4 commits into
Open
Conversation
yamaceay
force-pushed
the
fix/aicore-service-key-fix-docs
branch
2 times, most recently
from
September 8, 2026 09:49
bb1b0a2 to
098033e
Compare
mwien
reviewed
Sep 8, 2026
alpkom
requested changes
Sep 9, 2026
alpkom
left a comment
alpkom
left a comment
Contributor
There was a problem hiding this comment.
I've missed your previous PR for actually implementing this. I've just checked and it looks like you implemented the precedence of credentials different than the way it's handled in LiteLLM. Since the LiteLLM one is implemented first, and this is not documented yet, Let's first align the precedence and then document it.
The precedence should be:
kwargs → service key → env (AICORE_*) → config → VCAP service.
@yamaceay could you please adjust the implementation first and then document it accordingly?
yamaceay
force-pushed
the
fix/aicore-service-key-fix-docs
branch
from
September 9, 2026 09:20
adfe654 to
d149bb0
Compare
yamaceay
force-pushed
the
fix/aicore-service-key-fix-docs
branch
2 times, most recently
from
September 9, 2026 11:56
5fbb8ea to
69f9927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does and why it is needed
This PR aims to fix the inconsistencies of (1) docstring of
AICoreV2Client.from_envmethod and (2) the authentication section ofpackages/gen/gen_ai_hub/docs/README.md. The changes are related to the closed SAP/ai-sdk-python-backlog#1.Definition of Done