fix(dasp_signal): make boxed feature actually build the intended module - #205
Open
AlexTMjugador wants to merge 1 commit into
Open
AlexTMjugador wants to merge 1 commit into
AlexTMjugador wants to merge 1 commit into
Conversation
…dule While working on RustAudio#204, a relatively recently-introduced compiler warning about `features` not being a recognized `cfg` condition name caught my attention. After taking a look at the underlying code, I realized that it had the consequence of rendering the `boxed` feature of `dasp_signal` non-functional, since it always evaluated to false and thus the `boxed` module containing a `Signal` implementation for boxed signals was not compiled in. To fix that, these changes correct the identified `cfg` typo.
Contributor
Author
|
I tried to stack this PR on top of #204 using the new GitHub stacked pull requests feature, but that failed spectacularly: the These newfangled, slop-coded, churned-out features are truly a sight to behold, especially when considering that e.g. GitLab has had a working, much simpler stacked merge requests feature for years, which works automagically as long as an MR branch is based on another MR branch... 😅 Anyway, that means I ended up cherry-picking the specific commit for this PR on top of |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #204, a relatively recently-introduced compiler warning about
featuresnot being a recognizedcfgcondition name caught my attention. After taking a look at the underlying code, I realized that it had the consequence of rendering theboxedfeature ofdasp_signalnon-functional, since it always evaluated to false and thus theboxedmodule containing aSignalimplementation for boxed signals was not compiled in.To fix that, these changes correct the identified
cfgtypo.