Skip to content

macOS: fix Window::is_open returning the opposite - #374

Open
kovaacs wants to merge 1 commit into
RustAudio:masterfrom
kovaacs:macos-is-open
Open

kovaacs wants to merge 1 commit into
RustAudio:masterfrom
kovaacs:macos-is-open

Conversation

@kovaacs

@kovaacs kovaacs commented Nov 18, 2026

Copy link
Copy Markdown

On macOS WindowHandle::is_open returned self.state.closed.get(), so Window::is_open() was false while the window was open and true after it closed. It now returns !self.state.closed.get(), matching Windows (is_alive) and X11 (!stopped).

Found while reading the macOS backend for #372; I haven't hit it at runtime.

is_open returned state.closed; it returns whether the window is still
open, as on Windows (is_alive) and X11 (!stopped).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant