Repository navigation
Conversation
WindowWaker::request_redraw_after now also sets state.redraw_requested, as WindowContext::request_redraw does, so trigger_frame keeps the display link running for a redraw requested while draw() runs. Fixes RustAudio#372
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #372.
WindowWaker::request_redraw_afternow also setsstate.redraw_requested, asWindowContext::request_redrawdoes, sotrigger_framekeeps the display link running for a redraw requested whiledraw()runs.Tested on macOS: an editor embedded in an
NSWindowtest host that asks for its next frame through the waker duringdraw()went from 1 frame and then none to about 120 frames a second, and a CLAP plug-in using egui-baseview 0.9 in Bitwig 6.1 animates again without mouse movement.It could instead share one helper with
WindowContext::request_redraw; I kept it to the one line, but I'm happy to change it.