patch to avoid blocking initial dev setup when overview can't be built - #1348
Open
oscarlevin wants to merge 1 commit into
Open
patch to avoid blocking initial dev setup when overview can't be built#1348oscarlevin wants to merge 1 commit into
oscarlevin wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents the course index page from failing during initial dev setup when the library “book” record can’t be retrieved (e.g., when the underlying book/build state is broken or missing), by guarding access to book.social_url.
Changes:
- Make
has_discussion_groupresilient tobookbeingNonewhen renderingcurrent_course.html.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it would probably be better to fix the underlying issue, that the database starts with testuser1 as enrolled in the "overview" book which can no longer easily be built, but this would move around that at least for now. Plus would be safe in the future.