Skip to content

[Fix] Slack replies quote internal idle-session context - #847

Merged
daniel-lxs merged 8 commits into
developfrom
fix/strip-idle-quote-context-15t72sh7b06sy
Jul 28, 2026
Merged

[Fix] Slack replies quote internal idle-session context#847
daniel-lxs merged 8 commits into
developfrom
fix/strip-idle-quote-context-15t72sh7b06sy

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Daniel Riccio. Follow up by mentioning @roomote-roomote, in the web UI, or in Discord.

What changed

Prompt and steering delivery carry raw quote text separately from enriched agent prompts. GitHub follow-ups now pass the original comment body for active delivery and resume handoff.

Why this change was made

GitHub follow-up prompts include routing envelopes that must remain available to the agent but must not appear in Slack or Discord quotes.

Impact

GitHub-triggered replies quote only the commenter's text, not the internal follow-up envelope.

@roomote-roomote

roomote-roomote Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

1 issue outstanding. See task

  • apps/worker/src/sandbox-server/procedures/slackQuoteTracking.ts:18 Preserve the defensive malformed GitHub envelope fallback. — dismissed: the fallback only removed the wrapper marker, not embedded platform context. The shipped web path now passes the pre-injection quoteText directly to quote tracking, so injected context never enters the quote input.
  • apps/web/src/trpc/commands/sandbox-session/index.ts:304 Task-tool requests sent from TaskToolsButton now bypass the web quoteText requirement, so tool dispatch remains usable without a prompt.
  • apps/worker/src/run-task/run-task.ts:1840 Forward resumeQuoteText when delivering the deferred resume prompt. The new API payload field is never read by the resumed worker, and HarnessManager.sendFollowUpPrompt only receives the enriched resumePrompt, so snapshot-resumed GitHub follow-ups still quote the full <github-pr-follow-up> envelope.

Reviewed eaa9da9

@roomote-roomote

roomote-roomote Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Dismissed the fallback finding after tracing the quote input path.

The removed fallback only stripped the <github-pr-follow-up> marker; it could not safely remove embedded platform content. The shipped fix preserves the raw user message as quoteText before out-of-band context is injected, and quote tracking uses that raw value. The regression test verifies the agent receives the enriched prompt while the quote receives only the user text.

No code change was needed.

@daniel-lxs
daniel-lxs marked this pull request as ready for review July 28, 2026 14:16
@daniel-lxs
daniel-lxs merged commit a895194 into develop Jul 28, 2026
18 checks passed
@daniel-lxs
daniel-lxs deleted the fix/strip-idle-quote-context-15t72sh7b06sy branch July 28, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant