fix: align profile environment classification with actual support level#243
Open
SemTiOne wants to merge 1 commit into
Open
fix: align profile environment classification with actual support level#243SemTiOne wants to merge 1 commit into
SemTiOne wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
_infer_profile_classreadprofile["name"](doesn't exist, real path ismetadata.name), so every profile silently classified as "local" regardless of declared environment. Fixed to readmetadata.environment. Added schema enum, aproductionSuitablemodule flag, and CDS-SEC-073 to catch a non-local profile using a dev-only module; fixed the vault profile/module, which had exactly that contradiction.closes #217
Type Of Change
User Impact
Security rules using
profileClassesnow evaluate against the real declared environment instead of always seeing "local".Validation
136 passed, 1 skipped.
python -m unittest discover -s tests -p "*.py"Checklist
Does NOT resolve
metadata.environmentisn't enforced byvalidate_profile_shape; invalid/missing values silently default to "local". Fixing that touches ~40 fixtures across 4 test files (separate issue).