Repository navigation
feat(brain): ADR 0001 F1 — signed packs (kimetsu_pack 2) - #56
Merged
Merged
Conversation
ADR 0001 (Proposed): mounts, store ops, signed packs, iroh bus, Rust SDK, F0–F3.
Expand ADR 0001 (Proposed): mount levels and grants, store ops, signed packs, iroh P2P bus, Rust SDK, performance budgets, F0–F3.
New events store repo for a project input, while retrieval still reads stored project rows and labels them repo. Cite takes helped, noop, or harmed, and only helped can raise usefulness. Contamination checks cover merge, replace, replay, warm-start lanes, and a repo-only MCP read. Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
Sign the scrubbed canonical body with BLAKE3 and Ed25519, keep a local trust store, and reject scope mismatches before any SQL write. Unknown signers quarantine. Unsigned v1 import stays. Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
RodCor
commented
Nov 5, 2026
RodCor
left a comment
RodCor
left a comment
Owner
Author
There was a problem hiding this comment.
verdict: fail on ci only / would request changes (own-PR limitation)
f1 signed-pack contract is met: kimetsu_pack 2, blake3 + ed25519 verify_strict, scope mismatch with no sql, trust store, quarantine for unknown signer, v1 local narrowed, no iroh. tests cover tamper/scope/untrusted/v1.
blocker (inherited from #55): crates/kimetsu-brain/src/episode.rs:358 clippy. fix on #55 and restack — then f1 looks approve-ready.
nit: prefer checking sorted/unique scopes before ed25519 verify for clearer errors (still rejects today).
Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
…-12d7 Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
…s-12d7 Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com> # Conflicts: # CHANGELOG.md # crates/kimetsu-brain/src/mount.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements ADR 0001 F1 (signed packs) stacked on F0 (#55).
kimetsu_pack2: BLAKE3-256 of scrubbed canonical body + Ed25519 (ed25519-rfc8032-verify-strict)~/.kimetsu/trust.jsonor$KIMETSU_TRUST_STORECanonical pin
kimetsu-canon-json/1(not RFC 8785): UTF-8, keys sorted by raw bytes, no insignificant whitespace; signature over scrubbed body omittingsigner/signature.Tests
cargo test -p kimetsu-brain --lib→ 775 passed (F0 mount tests still green). Tamper/scope/strip/untrusted/strict/v1 parser cases green.Stack
cursor/f0-local-mount-34c9(feat(brain): ADR 0001 F0 — local mount grants and cite outcomes #55) @1420d06bc247269f37f459595e402145b8e57fffb4032db