Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
🧰 Additional context used📓 Path-based instructions (3)Format JavaScript and TypeScript code with Oxfmt using the repository configuration: tabs, single quotes, 130-character width, no trailing commas, omitted arrow-function parentheses where possible, and same-line brackets.📄 CodeRabbit inference engine (CLAUDE.md) Files:
Use descriptive names for functions, variables, and classes that clearly convey their purpose Write comments that explain the 'why' behind code decisions, not the 'what' Keep functions small and focused on a single responsibility Use const...📄 CodeRabbit inference engine (AGENTS.md) Files:
Use TypeScript for type safety; add explicit type annotations to function parameters and return types Prefer interfaces over type aliases for defining object shapes in TypeScript Use enums for sets of related constants rather than magic str...📄 CodeRabbit inference engine (AGENTS.md) Files:
🔇 Additional comments (3)
WalkthroughThe change replaces dotenv-based environment handling with build-time variable inlining, strict ChangesEnvironment variable handling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to The migration preserves the supported Storybook and E2E workflows and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Errors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Android Build Available Rocket.Chat 4.77.0.109581 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNRUK4h0ZjmPoNWxIHwx6ZRFLZ0FbkIPS3fLdcZT5NpyhDtcZmmRaKtO8NFDiQheFGjEue43ApkMH2LDmFs0 |
|
iOS Build Available Rocket.Chat 4.77.0.109582 |
|
Android Build Available Rocket.Chat 4.77.0.109592 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNTYRu4oJrhCBP8InZ57daSeeQQu0Ssczw0sTibgfyAPjemL-tNrtr8j1mkcg_8q6rXylI4MdegFyr3C1QH9 |
|
iOS Build Available Rocket.Chat 4.77.0.109591 |
Proposed changes
Replace
react-native-dotenv(@envimports) withbabel-plugin-transform-inline-environment-variables, inliningRUNNING_E2E_TESTSandUSE_STORYBOOKviaprocess.env. This removes a dependency and aligns the last two truthy env checks (index.js,InAppNotification) with the strict=== 'true'pattern already used everywhere else. Also adds--reset-cachetoe2e:start(matchingstorybook:start), since env values are inlined at bundle time.Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-1497
How to test or reproduce
pnpm installthenpnpm start: app boots into the normal app (not Storybook).pnpm storybook:start: Storybook loads.pnpm e2e:start: Metro serves E2E mocks (e.g. longer toast / in-app notification durations, exposed password fields).oxfmt --checkclean,tsc --noEmitclean,oxlintshows only one pre-existingexhaustive-depswarning inInAppNotification,jest app/containers/InAppNotificationpasses (4/4).Screenshots
N/A (no UI changes).
Types of changes
Checklist
Further comments
pnpm-lock.yamlis marked-diffin.gitattributes, so it shows as binary in the diff. Besides the expected add/remove of the two babel deps,pnpm installalso dropped a staleintegrityhash on the git-hosted@rocket.chat/sdktarball resolution — auto-generated noise, no manual edits to the lockfile. No remaining@env/react-native-dotenvreferences in code (verified with search).Summary by CodeRabbit
Bug Fixes
true.Chores