Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/containers/MessageComposer/MessageComposer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export const MessageComposer = ({

const closeEmojiKeyboardAndAction = (onClosed?: Function, params?: any) => {
resetKeyboard();
onClosed && onClosed(params);
onClosed?.(params);
};

useImperativeHandle(forwardedRef, () => ({
Expand Down
4 changes: 3 additions & 1 deletion app/containers/MessageComposer/MessageComposerContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ import { MessageComposer } from './MessageComposer';
import { EmojiKeyboardProvider } from './hooks/useEmojiKeyboard';
import { ComposerAttachments } from './components/Attachments/ComposerAttachments';

const defaultChildren = <ComposerAttachments />;

export const MessageComposerContainer = forwardRef<IMessageComposerRef, IMessageComposerContainerProps>(
({ children = <ComposerAttachments /> }, ref): ReactElement => {
({ children = defaultChildren }, ref): ReactElement => {
return (
<MessageComposerProvider>
<EmojiKeyboardProvider>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { AccessibilityInfo } from 'react-native';
import I18n from '../../../../i18n';
import { useIsAutocompleteVisible } from '../../../../views/RoomView/stores/ComposerStore';

const DELAY_TO_AVOID_KEYBOARD_ANNOUNCEMENT_CONFLICT = 800;

export const useAutocompleteA11yAnnounce = (): void => {
const isAutocompleteVisible = useIsAutocompleteVisible();

Expand All @@ -12,10 +14,9 @@ export const useAutocompleteA11yAnnounce = (): void => {
return;
}

// timeout to prevent conflict with default keyboard announcement.
const timeout = setTimeout(() => {
AccessibilityInfo.announceForAccessibility(I18n.t('The_autocomplete_options_are_available_above_the_input_composer'));
}, 800);
}, DELAY_TO_AVOID_KEYBOARD_ANNOUNCEMENT_CONFLICT);

return () => clearTimeout(timeout);
}, [isAutocompleteVisible]);
Expand Down
6 changes: 3 additions & 3 deletions app/containers/MessageComposer/components/CancelEdit.tsx
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { BaseButton } from './Buttons';
import { useEditCancel } from '../../../views/RoomView/stores/ComposerStore';
import { useMessageAction } from '../../message/stores/MessageActionStore';
import { useMessageActionKind } from '../../message/stores/MessageActionStore';
import { Gap } from './Gap';

export const CancelEdit = () => {
Comment thread
coderabbitai[bot] marked this conversation as resolved.
const editCancel = useEditCancel();
const action = useMessageAction();
const actionKind = useMessageActionKind();

if (action?.kind !== 'edit') {
if (actionKind !== 'edit') {
return null;
}
return (
Expand Down
Loading
Loading