chore(sdk): regenerate from API 1.9.x - #199
Merged
Merged
Conversation
First regeneration in some time, so this carries accumulated surface, not one change. Everything removed is named below. REMOVED (one type, one union member in two places): - SecConnectionConfig, and the sec_config field on the create-connection request - 'sec' from the provider union on create-connection and list-connections The SEC connection provider is gone from the API (robosystems #1248). It was a filing-driven entity-creation path predating the shared SEC repository, disabled in every deployed environment, and its sync had degenerated to a no-op reported as a pending operation. SEC filings still arrive nightly into the shared SEC repository; only the per-graph connection surface goes. Nothing else is removed in the diff. This lives in the generated /sdk tree, which the two-tier contract puts in the generated tier, so it rides a minor. The facades — LedgerClient, InvestorClient, LibraryClient — never referenced it. It also meets the dead-surface clause independently: it never functioned in a shipped configuration, its only consumer was the roboledger-app UI removed in roboledger-app #316, and the change is symbol resolution only. ADDED: - terminateSchedule, with TerminateScheduleRequest/Response(2), TerminateScheduleData/Error(s)/Responses and OperationEnvelopeTerminateScheduleResponse - CloseReceipt in the generated GraphQL types CHANGED, DESCRIPTIONS ONLY: - syncConnection documents the split the API made real: QuickBooks returns a pending envelope carrying the run's task_id, while a push-based provider returns completed with a null task_id and nothing to poll - createConnection and getConnectionOptions drop their SEC clauses Version left at 1.10.1 to bump at publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to RoboFinSystems/robosystems-python-client#192. This carries accumulated API surface, not one change — everything removed is named below.
Removed — one type, one union member in two places
SecConnectionConfigtypes.gen.tsand root exportssec_config'sec'The SEC connection provider is gone from the API (RoboFinSystems/robosystems#1248). It was a filing-driven entity-creation path predating the shared SEC repository, disabled in every deployed environment (
CONNECTION_SEC_ENABLED=falsein both prod and staging SSM, since deleted), and its sync had degenerated to a no-op reported as a pending operation.SEC filings still arrive nightly into the shared SEC repository. Only the per-graph connection surface goes.
I diffed the full export symbol set (both
export {}andexport type {}insdk/index.ts):SecConnectionConfigis the only removal; everything else is additive.Why a minor, not a major
SecConnectionConfiglives in the generated/sdktree, which the two-tier contract explicitly places in the generated tier — moved on a client minor with each removal named. The facades (LedgerClient,InvestorClient,LibraryClient) never referenced it; I greppedclients/to confirm it appears nowhere outsidesdk/.It also satisfies the dead-surface clause independently: it never functioned in a shipped configuration, its only consumer was the roboledger-app UI removed in RoboFinSystems/roboledger-app#316, and the change is symbol resolution only.
Added
terminateSchedule, withTerminateScheduleRequest/Response(2),TerminateScheduleData/Error(s)/Responses, andOperationEnvelopeTerminateScheduleResponseCloseReceiptin the generated GraphQL types (+44 lines)Changed — descriptions only
syncConnectiondocuments the split the API made real: QuickBooks returns apendingenvelope carrying the run'stask_id; a push-based provider returnscompletedwith a nulltask_idand nothing to poll. The prior text still described SEC downloading EDGAR filings in 5–10 minutes, which had not been true for some time.createConnectionandgetConnectionOptionsdrop their SEC clauses.Validation
npm run test:allgreen — prettier, eslint,tsc --noEmit, 10 test files / 302 tests, and a cleantscbuild. Pre-commit re-ran the same gate.Version left at 1.10.1 for you to bump at publish.