Skip to content

feat(storyteller): request queue identity unification, envelope hints, and CI test workflow - #22

Merged
mcocdaa merged 1 commit into
mainfrom
feat/building-block-architecture
Nov 7, 2026
Merged

mcocdaa merged 1 commit into
mainfrom
feat/building-block-architecture

Conversation

@mcocdaa

@mcocdaa mcocdaa commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • feat(storyteller): request queue identity unification, envelope hints, and CI test workflow
  • Automated CI unit test workflow via RimWorld-RimMind-Mod/Workflows.

…, and CI test workflow

fix(storyteller): align queue cooldown key with envelope mod id

The forced-request path cleared the "Storyteller" cooldown while Core
stores per-mod cooldowns under the envelope ModId ("RimMind.Storyteller"),
so the clear silently targeted a key that never existed. Introduce
StorytellerRequestIds.RequestModId as the single source of truth and use
it for the envelope, cooldown clear, and StorytellerModCooldown.

Also register a typed StorytellerStateChangedEvent on the bus before any
context key names it, since unknown trigger names never fall back to the
base bus event, and publish it after dialogue turns so cached context
reaches the next prompt. Register the Storyteller scenario descriptor,
use JsonRepairer for truncated responses, and add a contract test plus
CI workflow to guard the queue identity.
@mcocdaa
mcocdaa merged commit d9e0acc into main Nov 7, 2026
1 check failed
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@mcocdaa
mcocdaa deleted the feat/building-block-architecture branch November 7, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant