Repository navigation
feat(personality): IncidentWorker.TryExecute patch fix, GameEventHub & ThoughtSpec migration, and CI test workflow - #23
Merged
Conversation
…& ThoughtSpec migration, and CI test workflow fix(personality): correct incident patch target and unify cooldown scaling Patch IncidentWorker.TryExecute instead of the protected virtual TryExecuteWorker, which concrete workers override so the base patch rarely fired. Guard the incident translation key with CanTranslate and fall back to a plain string. Extract activity cooldown scaling into ActivityCooldownScaler and reuse it in CompAIPersonality and PersonalityModCooldown. Align the cooldown OwnerModId with PersonalityRequestDefaults.ModId so Core resolves queue cooldowns by the same key as the request envelope. Register the Personality scenario descriptor with relevance weights and drop the unused PersonalityEvent invalidation triggers, relying on the 750-tick staleness window instead. Publish SkillLevelUpGameEvent on skill level up and delegate translation helpers to RimMindText.TrOr. Add contract tests covering patch targets, incident trigger policy, and cooldown key alignment, plus a CI workflow for unit tests.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RimWorld-RimMind-Mod/Workflows.