Skip to content

feat(bridge-rimchat): fix ActionGate return check, migrate onto Core Bridge Kit, add CI test workflow - #20

Merged
mcocdaa merged 1 commit into
mainfrom
feat/building-block-architecture
Nov 7, 2026
Merged

mcocdaa merged 1 commit into
mainfrom
feat/building-block-architecture

Conversation

@mcocdaa

@mcocdaa mcocdaa commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • feat(bridge-rimchat): fix ActionGate return check, migrate onto Core Bridge Kit, add CI test workflow
  • Automated CI unit test workflow via RimWorld-RimMind-Mod/Workflows.

…Bridge Kit, add CI test workflow

refactor: adopt shared core helpers for reflection, detection, and skip checks

Replace duplicated reflection and soft-dependency logic with shared
ReflectionAccessor and SoftDependencyDetector from RimMind-Core, and
switch skip checks to IChannelSkipCheck with open string channels.

- ActionGate: case-insensitive matching plus prefix-based classification
  for romance, social, diplomacy, and recruit intents to cover real
  mechanism and tool prefixes
- DialogueGate: use shared DialogueTriggerKinds constants
- ContextPullBridge: drop RimChatEvent invalidation triggers since
  RimChat state changes are external; rely on staleness only
- Add unit test workflow and contract tests for new gate behavior
@mcocdaa
mcocdaa merged commit 301e43d into main Nov 7, 2026
1 check passed
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@mcocdaa
mcocdaa deleted the feat/building-block-architecture branch November 7, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant