Repository navigation
feat(advisor): manifest-driven risk triage, tool call batch isolation, and CI test workflow - #22
Merged
Merged
Conversation
…, and CI test workflow fix(advisor): unify cooldown source, queue identity, and per-call tool isolation - Derive every readiness check from a single activity-scaled effective cooldown (AdvisorCooldownCalculator.CalculateEffectiveCooldown), removing the duplicated scaling in AdvisorGameComponent and applying the same scaling to the Core queue cooldown. - Introduce AdvisorRequestIds.RequestModId so the envelope ModId, Core cooldown key, and AdvisorModCooldown.Id can no longer diverge. - Resolve tool risk and autonomy domains dynamically via Core's ClassifyPolicy/manifest instead of a hardcoded Actions tool map, so argument-dependent policies (e.g. survival bed placement) are honored. - Isolate each tool call in a batch: a throwing, faulted, or asynchronous handler fails only that call, preserving real results of calls whose side effects already ran. - Register and publish AdvisorHistoryChangedEvent so the advisor_history context key invalidates on history changes. - Add CI workflow and contract tests covering queue identity, tool isolation, and cooldown scaling.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RimWorld-RimMind-Mod/Workflows.