Skip to content

Vdp2/rotation param b - #137

Merged
seven-shades merged 14 commits into
mainfrom
Vdp2/rotation-param-B
Aug 15, 2026
Merged

Vdp2/rotation param b#137
seven-shades merged 14 commits into
mainfrom
Vdp2/rotation-param-B

Conversation

@seven-shades

@seven-shades seven-shades commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

-Added SRL Wrapper support for Rotation Parameter B in the RBG0 interface:
-Overloads for RBG0 loading functions allow loading 2 tilemaps where the secondary displays with Parameter B.
-Config for Parameter B can be made by specifying the enum RotationParameter::Secondary in the overloads.
-Added Functionality in the ScrollScreen Interface to Register any ScrollScreen to display the ASCII Scroll.
-Added Additional Sample demonstrating loading and switching fonts on the ASCII Scroll.
-Added Additional Sample demonstrating use of Both Rotation Parameters on RBG0.
-Additional changes to documentation and VDP2 samples.

seven-shades and others added 9 commits December 29, 2025 15:21
@seven-shades
Added Rotation parameter switching to RBG0 interface
e49fff1
@seven-shades
Bug Fix- calling Transparent Disable no longer breaks VDP1 layer display
de1835f
@seven-shades
-Made Map2Vram and Cell2VRAM public.
2f39796 
-ClearVRAM() : Added optional param to disable clearing palettes.
-LoadTilemap()/LoadBitmap(): Added optional param to disable auto loading palettes
@seven-shades
Update:
b27b036 
- Added Rotation RB tilemap loading
-Added LoadTilemap overloads to streamline loading 2 tilemaps to RBG0
-Added Functions to adjust scale reduction limit in NBG0 and NBG1 interfaces
-Adjustments to VRAM automap allocation
-Minor documentation fixes
@seven-shades
Fix Docs
85462e7
@seven-shades
Updates:
c057647 
-Modified interface control of RBG0RB
-Added Rotation Parameter sample
-Bug Fixes
@seven-shades
Test Changes
db8a0ef
@seven-shades
Merge pull request #136 from ReyeMe/main
f293db5 
Merge from main
@seven-shades
Additions/ Fixes to VDP2 Samples
0d1701f
ReyeMe
ReyeMe requested changes Jul 31, 2026
View reviewed changes

@ReyeMe ReyeMe left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes are needed

Comment thread Samples/VDP1 - 3D - Smooth teapot/src/main.cxx Outdated
// Initializes gouraud table work area
SRL::Scene3D::LightInitGouraudTable(0, vertWork, workTable, polygons);

@ReyeMe ReyeMe Jul 31, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless change, plese revert

Comment thread Samples/VDP2 - RBG0 Rotation Parameters/src/main.cxx Outdated
int main()
{
SRL::Core::Initialize(HighColor(20,10,50));
Digital port0(0); // Initialize gamepad on port 0

@ReyeMe ReyeMe Jul 31, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gamepad is never used

Comment thread saturnringlib/srl_tilemap_interfaces.hpp Outdated
// Check that requested page indicies exist in this map:
if (!this->mapData || sourcePage >= this->numPages || destPage >= numPages)
{
{

@ReyeMe ReyeMe Jul 31, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken formatting

Comment thread saturnringlib/srl_vdp2.hpp Outdated
if (info.PlaneSize == PL_SIZE_2x2) page_sz <<= 2;
else if (info.PlaneSize == PL_SIZE_2x1) page_sz <<= 1;

//if(info.MapByteSize)sz = info.MapByteSize;

@ReyeMe ReyeMe Jul 31, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code

Comment thread saturnringlib/srl_vdp2.hpp
@ReyeMe ReyeMe added enhancement New feature or request required hardware test Issues marked with this label must be tested on real HW before merging. labels Aug 7, 2026
ReyeMe
ReyeMe requested changes Aug 7, 2026
View reviewed changes

@ReyeMe ReyeMe left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small things to patch

Comment thread saturnringlib/srl_scene2d.hpp Outdated
Comment thread saturnringlib/srl_scene3d.hpp Outdated
Comment thread saturnringlib/srl_tilemap_interfaces.hpp Outdated
Comment thread saturnringlib/srl_vdp2.hpp Outdated
Comment thread saturnringlib/srl_vdp2.hpp Outdated
Comment thread saturnringlib/srl_vdp2.hpp Outdated
Comment thread saturnringlib/srl_vdp2.hpp
Comment thread saturnringlib/srl_vdp2.hpp Outdated
Comment thread saturnringlib/srl_vdp2.hpp Outdated
Comment thread saturnringlib/srl_vdp2.hpp
@seven-shades
-More formatting Fixes.
62832e7 
-Rreapplied math fix to VDP2   ColorCalc demo
@bimmerlabs

bimmerlabs commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Tested all samples on my VA1 US Saturn. I also built my game engines, PPP and PPE with it.

I only noticed the STL sample appears to be incomplete - that is not an issue with this PR though, it should be either updated or removed separately.

As noted, the color calc sample was regressed to a previous version. the fixed version from the workarea fix branch does work though

bimmerlabs
bimmerlabs reviewed Aug 14, 2026
View reviewed changes
Comment thread Samples/ASCII - Fonts/makefile Outdated
SGL_MAX_WORKS = 1 # Number of works that can be used

# Disk name
CD_NAME = VDP2_ScrollScreen

@bimmerlabs bimmerlabs Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update the CD_NAME

bimmerlabs
bimmerlabs reviewed Aug 14, 2026
View reviewed changes
Comment thread Samples/VDP2 - RBG0 Rotation Parameters/makefile Outdated
SGL_MAX_WORKS = 1 # Number of works that can be used

# Disk name
CD_NAME = VDP2_ScrollScreen

@bimmerlabs bimmerlabs Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update CD_NAME

bimmerlabs
bimmerlabs reviewed Aug 14, 2026
View reviewed changes
Comment thread Samples/VDP2 - RBG0 Rotation/src/main.cxx Outdated
-Snes Mode7 style effect like Mario Kart/F-Zero
-Works for 3D ground in games where there is no rolling around camera's axis*/
-SNES Mode 7 style floor effect like Mario Kart/F-Zero
-Works for 3D ground/cieling pland in games where there is no rolling around the camera's axis*/

@bimmerlabs bimmerlabs Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo
"ceiling plane"?

bimmerlabs
bimmerlabs reviewed Aug 14, 2026
View reviewed changes
Comment thread saturnringlib/srl_vdp2.hpp Outdated
bimmerlabs
bimmerlabs reviewed Aug 14, 2026
View reviewed changes

@bimmerlabs bimmerlabs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments/typos

all samples verified on hardware (VA1 NTSC)

also verified that the VDP2 Color Calc sample is fine / unchanged.

ReyeMe
ReyeMe approved these changes Aug 15, 2026
View reviewed changes

@ReyeMe ReyeMe left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@seven-shades
seven-shades merged commit 0f8af63 into main Aug 15, 2026
1 check passed
@seven-shades
seven-shades deleted the Vdp2/rotation-param-B branch August 15, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bimmerlabs bimmerlabs bimmerlabs left review comments
@ReyeMe ReyeMe ReyeMe approved these changes

Assignees

@seven-shades seven-shades

Labels

enhancement New feature or request required hardware test Issues marked with this label must be tested on real HW before merging.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seven-shades @bimmerlabs @ReyeMe