feat: define branded loading state hierarchy with shimmer token#191
Open
theFirstCodeManiac wants to merge 1 commit into
Open
feat: define branded loading state hierarchy with shimmer token#191theFirstCodeManiac wants to merge 1 commit into
theFirstCodeManiac wants to merge 1 commit into
Conversation
- Add --shimmer-gradient design token to :root in index.css - Add @Keyframes shimmer, spin-loader with prefers-reduced-motion fallback - Add CSS classes: .animate-shimmer, .animate-spin-loader, .skeleton, .skeleton-text/title/avatar/rect, .progress-bar-*, .page-loader-* - New LoadingSpinner component: aria-hidden-aware, uses animate-spin-loader - New ProgressBar component: determinate + indeterminate modes, WCAG progressbar role - New PageLoader component: full-screen overlay, role=status, aria-live=polite - New Skeleton component: 5 variants, count prop, aria-hidden=true - Refactor Button to use LoadingSpinner instead of raw Loader2 - Refactor AuthSubmitButton to use LoadingSpinner - Refactor StatusTimeline in-progress icon to use LoadingSpinner - Add docs/LOADING_STATES.md: latency thresholds, usage guidelines, examples WCAG 2.1 AA: - Spinners include role=img + aria-label when visible; aria-hidden when decorative - Shimmer pauses under prefers-reduced-motion - ProgressBar exposes aria-valuenow / aria-valuemin / aria-valuemax - PageLoader announces via aria-live=polite Refs: feat/loading-progress-hierarchy
|
@theFirstCodeManiac Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151
Pull Request
Summary
Introduced a unified loading state system across the application with consistent branded visuals, accessible behavior, and responsive design. Added standardized button spinners, inline progress indicators, page loaders, and section skeletons powered by a shared shimmer token.
Changes Made
src/components/Button.tsxto use the standardized button loading statearia-labelsupport to spinner components for accessibilityprefers-reduced-motionTesting
prefers-reduced-motionis enabledaria-labelattributesAcceptance Criteria