Skip to content

fix(data-types): migrate sync to v3 signatures API #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
r0ny123 wants to merge 1 commit into from
Closed

fix(data-types): migrate sync to v3 signatures API #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 17 additions & 26 deletions reai_toolkit/app/services/data_types/data_types_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,15 @@
from loguru import logger

from reai_toolkit.app.core.netstore_service import SimpleNetStore
from revengai import (
FunctionsDataTypesApi,
FunctionDataTypesList,
BaseResponseFunctionDataTypesList
)
from revengai import FunctionDataTypesList

from reai_toolkit.app.interfaces.thread_service import IThreadService
from reai_toolkit.app.services.data_types.v3_data_types import (
list_function_signatures,
to_legacy_function_data_types,
)
from reai_toolkit.app.transformations.import_data_types import ImportDataTypes


FUNCTION_IDS_BATCH_SIZE = 50


@dataclass
class DataTypesImportResult:
error: str | None = None
Expand Down Expand Up @@ -60,12 +56,11 @@ def import_data_types(
logger.error(f"RevEng.AI: failed to sync function data types: {e}")
return DataTypesImportResult(error=f"Failed to sync function data types: {e}")

present_ids: set[int] = (
{item.function_id for item in response.items if item.data_types is not None}
if response
else set()
)
remote_absent_ids: set[int] = set(matched_function_ids) - present_ids
# The v3 API distinguishes "no extracted signature" from a missing
# function. A missing signature is not a reason to send the old v2
# data-type blob back to the server, so do not turn it into a local
# push candidate.
remote_absent_ids: set[int] = set()

apply_failed_ids: set[int] = set()
if response:
Expand All @@ -82,15 +77,11 @@ def _get_data_types(self, function_ids: list[int] | None = None) -> FunctionData
if not function_ids:
return None

items = []
with self.yield_api_client(sdk_config=self.sdk_config) as api_client:
client = FunctionsDataTypesApi(api_client=api_client)
for start in range(0, len(function_ids), FUNCTION_IDS_BATCH_SIZE):
chunk = function_ids[start:start + FUNCTION_IDS_BATCH_SIZE]
response: BaseResponseFunctionDataTypesList = (
client.list_function_data_types_for_functions(function_ids=chunk) # type: ignore
)
if response.status and response.data:
items.extend(response.data.items)

return FunctionDataTypesList(items=items)
response = list_function_signatures(
api_client,
function_ids,
include_data_types=True,
)

return to_legacy_function_data_types(response)
Loading